Aaron Durbin submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved
dram-spd: Remove free()

free() is not needed since the memory is not dynamically allocated.

Change-Id: I90659722aaca6ced1e1cbc3db4180b0811205e95
Signed-off-by: Bora Guvendik <bora.guvendik@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37940
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
---
M src/vendorcode/cavium/bdk/libdram/dram-spd.c
1 file changed, 0 insertions(+), 1 deletion(-)

diff --git a/src/vendorcode/cavium/bdk/libdram/dram-spd.c b/src/vendorcode/cavium/bdk/libdram/dram-spd.c
index 894a060..8aec41c 100644
--- a/src/vendorcode/cavium/bdk/libdram/dram-spd.c
+++ b/src/vendorcode/cavium/bdk/libdram/dram-spd.c
@@ -105,7 +105,6 @@
int64_t data = bdk_twsix_read_ia(node, bus, address, i, 4, 1);
if (data < 0)
{
- free(spd_buf);
bdk_error("Failed to read SPD data at 0x%x\n", i + (bank << 8));
/* Restore the bank to zero */
if (bank)

To view, visit change 37940. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90659722aaca6ced1e1cbc3db4180b0811205e95
Gerrit-Change-Number: 37940
Gerrit-PatchSet: 2
Gerrit-Owner: Bora Guvendik <bora.guvendik@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid@intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi@google.com>
Gerrit-MessageType: merged