Attention is currently required from: Tarun Tuli, Martin L Roth, Nick Vaccaro.
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71628 )
Change subject: mb/google/brya/var/kano: Set the ov2740 to 0 and the hi556 to 1 for SSFC
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/kano/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/71628/comment/d3744236_bad33c4f
PS1, Line 20: option UFC_MIPI_OVTI2740 0
I still don't understand why UFC_MIPI_HI556 can't just be value 3 in the UFC field, and why the SSFC […]
If set UFC_MIPI_HI556 to value 3 in the UFC field, it needs to follow SKU ID to replace mipi camera, which is inconvenient for the factory side, so the factory suggests using SSFC.
Kano is a mass production device and does not use SSFC (only one mipi camera ov2740), so we keep the original UFC filed for kano, and then add SSFC for two mipi camera for zydron.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71628
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46fac6c820d6006956680a07198db82225630905
Gerrit-Change-Number: 71628
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Sat, 07 Jan 2023 05:39:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Wu
david_wu@quanta.corp-partner.google.com
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment