Attention is currently required from: Reka Norman, Paul Menzel, Rizwan Qureshi, Subrata Banik, Krishna P Bhat D, Usha P, Patrick Rudolph, Kangheui Won.
Patch set 7:Code-Review +1
4 comments:
Patchset:
Thank you! Other than a few nitpicks about cosmetics, LGTM.
File src/soc/intel/alderlake/Kconfig:
config SOC_INTEL_ALDERLAKE_PCH_N
bool
select SOC_INTEL_ALDERLAKE
help
Choose this option if your mainboard has a PCH-N chipset.
nit: Please move this between `SOC_INTEL_ALDERLAKE_PCH_M` and `SOC_INTEL_ALDERLAKE_PCH_P` to preserve alphabetical order (M ---> N ---> P)
Patch Set #7, Line 188: default 12 if SOC_INTEL_ALDERLAKE_PCH_N
nit: Same thing about alphabetical order (M ---> N ---> P) here, and for the other defaults
Patch Set #7, Line 208: default 6 if SOC_INTEL_ALDERLAKE_PCH_M
nit: I intentionally added a space here so that the `if SOC_INTEL_ALDERLAKE_PCH_` parts are aligned to the same column
To view, visit change 59752. To unsubscribe, or for help writing mail filters, visit settings.