Apologies, I hadn't seen that my replies were still drafts.
8 comments:
Patch Set #3, Line 10: P10S-M
I would not add this board until you have boot-tested it. […]
Probably not. At the moment, I've got the key CONFIG value commented out so it won't offer it as a build target. It just seemed to make sense to maintain the variant/ setup from the Supermicro board I'm basing this on.
Okay, I've dropped the variants/p10s-m directory and changed the wording in the latest commit. For now, p10s-i only, but it's set up
so maybe someday others in the same family can be done.
File src/mainboard/asus/p10s-series/devicetree.cb:
Patch Set #3, Line 3: Enable
I am not sure
Neither am I. Sure does look like it actually disables all that.
Changed in the latest push.
File src/mainboard/asus/p10s-series/dsdt.asl:
Patch Set #3, Line 33: // CPU
I would drop this comment
Dropped.
Scope (\_SB) {
Device (PCI0)
Device (\_SB. […]
Changed thusly.
Patch Set #3, Line 44: // Chipset specific sleep states
I just dropped these with CB:37855
Comment dropped.
File src/mainboard/asus/p10s-series/include/mainboard.h:
Patch Set #3, Line 21: #endif /* _OARD_ASUS_P10S_SERIES_H */
OARD?
Fixed.
File src/mainboard/asus/p10s-series/variants/p10s-i/include/variant/gpio.h:
How did you generate this?
I didn't. This is inherited verbatim from the Supermicro board I'm basing this on.
Replaced with values generated by a perl script I wrote that parses the output of inteltool -g and spits out the proper high-level macros. The new values still aren't quite exactly right but they're closer.
File src/mainboard/asus/p10s-series/variants/p10s-m/include/variant/gpio.h:
How did you generate this?
I didn't. This is inherited verbatim from the Supermicro board I'm basing this on.
File dropped.
To view, visit change 37995. To unsubscribe, or for help writing mail filters, visit settings.