Eric Lai submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved
mb/google/nissa/var/quandiso: Tune P-sensors for Linux 5.15 sx9324
driver

Since DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER value on dedede
cannot meet DRIVERS_I2C_SX9324 on nissa, need to update the tuning
value. Update proximity sensor fine tune value with quandiso EVT
machine.

BUG=b:314550601
BRANCH=firmware-nissa-15217.B
TEST=emerge-nissa coreboot and verify p-sensor
watch 'cat /sys/bus/iio/devices/iio:device*/*raw'

Change-Id: I5fc3bc5876594f2df79d628bd986113d37087c3d
Signed-off-by: Robert Chen <robert.chen@quanta.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79724
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <ericllai@google.com>
---
M src/mainboard/google/brya/variants/quandiso/overridetree.cb
1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/mainboard/google/brya/variants/quandiso/overridetree.cb b/src/mainboard/google/brya/variants/quandiso/overridetree.cb
index c28cc0b..21c9aba 100644
--- a/src/mainboard/google/brya/variants/quandiso/overridetree.cb
+++ b/src/mainboard/google/brya/variants/quandiso/overridetree.cb
@@ -290,10 +290,9 @@
register "desc" = ""SAR Proximity Sensor""
register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_H19_IRQ)"
register "speed" = "I2C_SPEED_FAST"
- register "uid" = "2"
-
- register "ph0_pin" = "{3, 1, 3}"
- register "ph1_pin" = "{1, 2, 2}"
+ register "uid" = "1"
+ register "ph0_pin" = "{1, 3, 3}"
+ register "ph1_pin" = "{3, 2, 1}"
register "ph2_pin" = "{3, 3, 1}"
register "ph3_pin" = "{1, 3, 3}"
register "ph01_resolution" = "1024"
@@ -304,7 +303,7 @@
register "avg_pos_strength" = "256"
register "cs_idle_sleep" = ""gnd""
register "int_comp_resistor" = ""lowest""
- register "input_precharge_resistor_ohms" = "4000"
+ register "input_precharge_resistor_ohms" = "2000"
register "input_analog_gain" = "3"
device i2c 28 on
probe DB_USB DB_LTE

To view, visit change 79724. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5fc3bc5876594f2df79d628bd986113d37087c3d
Gerrit-Change-Number: 79724
Gerrit-PatchSet: 8
Gerrit-Owner: Robert Chen <robert.chen@quanta.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai@google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org>
Gerrit-Reviewer: Shawn Ku <shawnku@google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Gwendal Grignou <gwendal@google.com>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged