View Change

4 comments:

• File src/mainboard/google/zork/spd/Makefile.inc:

  • Patch Set #3, Line 7: SPD_BLOB:=$(obj)/SPD_array.bin

    Does this need to be here? It's constructed in the picasso makefile.

  • Patch Set #3, Line 10: APCB_SOURCES:=$(FIRMWARE_LOCATE)/APCB_magic.bin

    Why is one even needed? Is this just to pass the validation check? If so, let's remove the check or make in an OR.

• File src/soc/amd/picasso/Makefile.inc:

  • Patch Set #3, Line 243: #ifdef SPD_SOURCES

    Is this ifdef necessary? PSP_SPD_FILES will just be empty when its not defined.

  • Patch Set #3, Line 247: SPD_BLOB:=$(obj)/SPD_array.bin

    Maybe this be SPD_ARRAY_BLOB since it may contain multiple SPDs

To view, visit change 45278. To unsubscribe, or for help writing mail filters, visit settings.