4 comments:
File src/mainboard/acer/es1-572/acpi/mainboard.asl:
No, PWRB isn't needed.
I wasn't sure. Some boards add it. the todo was more like "find out if it's needed"
File src/mainboard/acer/es1-572/gma-mainboard.ads:
License changed from GPL-2.0-or-later to GPL-2. […]
ack, will change that in the new change
File src/mainboard/acer/es1-572/gpio.c:
Patch Set #10, Line 191: void mainboard_configure_gpios(void)
This means GPIOs are programmed after FSP now?
yes
File src/mainboard/acer/es1-572/gpio_early.c:
/* Name format: <pad name> / <net/pin name in schematics> */
static const struct pad_config early_gpio_table[] = {
PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1), /* UART2_RXD / UART_2_CRXD_DTXD */
PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1), /* UART2_TXD / UART_2_CTXD_DRXD */
};
Are you sure this is required?
the pads default to GPI
To view, visit change 38978. To unsubscribe, or for help writing mail filters, visit settings.