1 comment:
File src/soc/amd/picasso/include/soc/data_fabric.h:
Patch Set #2, Line 62: BIT(0)
Hmm, we seem to oscillate back and forth. There was a big push before to use BIT().
i prefer the (1 << bit) notation; not sure if the BIT(bit) came from the UEFI side of things (or were there defines for each bit? not sure; all i remember is that i didn't like it). if in doubt, i tend to do what the native SNB/IVB code does; that one is what i consider being the most coreboot-ish code for a non-ancient platform. but yeah, i don't have too strong opinions on this one
To view, visit change 47726. To unsubscribe, or for help writing mail filters, visit settings.