Patch Set 37:

please split adding the EC from adding the mainboard

done

View Change

11 comments:

• File Documentation/mainboard/51nb/x210.jpg:

  • Patch Set #37:

    Please put this image into https://tinyjpg. […]

    Done

• File src/mainboard/51nb/x210/acpi/battery.asl:

  • Patch Set #37:

    Is this file using spaces? The other ACPI files seem affected as well

    Done

• File src/mainboard/51nb/x210/board.fmd:

  • Patch Set #37, Line 6: FLASH@0xff800000 0x800000

    FLASH 8M

    Done

• File src/mainboard/51nb/x210/devicetree.cb:

  • Patch Set #37, Line 59: 3

    SaGv_Enabled

    Done

  • Patch Set #37, Line 98: 0x0

    Just 0 (apply everywhere)

    Done

  • Patch Set #37, Line 229:

    nit: align the "on" keywords?

    Done

• File src/mainboard/51nb/x210/dsdt.asl:

  • Patch Set #37, Line 17:

    Should be making use of arch/acpi. […]

    Done

  • Patch Set #37, Line 30: global

    Either drop the comment, or capitalize `Global`

    Done

  • Patch Set #37, Line 33: // CPU

    This comment provides little value

    Done

  • Patch Set #37, Line 36:

    Scope (\_SB) {
    		Device (PCI0)
    

    Device (\_SB.PCI0) […]

    Done

• File src/mainboard/51nb/x210/hda_verb.c:

  • Patch Set #33, Line 39: /* Pin Complex (NID 0x19) */

    Ideally, I've yet to see that happen, though... One could also use higher-level macros as well. […]

    Done

To view, visit change 32531. To unsubscribe, or for help writing mail filters, visit settings.