6 comments:
File src/drivers/aspeed/common/ast_i2c.c:
backup = software_i2c[ASPEED_BUS];
software_i2c[ASPEED_BUS] = &ast_ops;
Well, I see what this code is doing. But it's just weird and a bad […]
I don't see a better solution
Patch Set #5, Line 133: ast = ast_priv;
I see that too.
Done
File src/drivers/aspeed/common/ast_mode.c:
/*
* Authors: Dave Airlie <airlied@redhat.com>
* Authors: 9Elements Agency GmbH <patrick.rudolph@9elements.com>
move up below copyright?
Done
*/
#include
newline after comment
Done
why two newlines?
in case one doesn't work well enough
File src/drivers/aspeed/common/ast_tables.h:
0x67,
{0x00, 0x03, 0x00, 0x02},
{0x5f, 0x4f, 0x50, 0x82, 0x55, 0x81, 0xbf, 0x1f,
0x00, 0x4f, 0x0d, 0x0e, 0x00, 0x00, 0x00, 0x00,
0x9c, 0x8e, 0x8f, 0x28, 0x1f, 0x96, 0xb9, 0xa3,
0xff},
{0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x14, 0x07,
0x38, 0x39, 0x3a, 0x3b, 0x3c, 0x3d, 0x3e, 0x3f,
0x0c, 0x00, 0x0f, 0x08},
{0x00, 0x00, 0x00, 0x00, 0x00, 0x10, 0x0e, 0x00,
0xff}
This is all cosmetic?
no the linter errors out if there's no whitespace
To view, visit change 35726. To unsubscribe, or for help writing mail filters, visit settings.