Comparing against Hudson code, I do agree with your changes. I wander why no side effect was found before. Maybe some of the code (with exception of SPI prefetch) could simply be removed (modern OS would re-initialize them as needed)?

I'll await an answer, otherwise I would approve it (if you say leave it there, I'll accept and approve).

View Change

To view, visit change 32551. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I078be974dc3c78c94cb7c0832518f21bac029ff2
Gerrit-Change-Number: 32551
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 03 May 2019 02:13:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment