Attention is currently required from: Furquan Shaikh.
3 comments:
File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
Patch Set #15, Line 33: [PchSerialIoIndexGSPI1] = 1,
Do we need to initialize GSPI for FPMCU? Wouldn't this be done by the OS?
Not sure here.
Patch Set #15, Line 105: #USB3-1 Type A
This comment doesn't really look right. Why does a PCIE RP device say USB3? Same for RP4 below.
Do we need to enable RP port if this is combo PCIE and USB?
Patch Set #15, Line 134: PCIE_RP_LTR
Why is LTR not enabled for WLAN and WWAN ports? Also, what about AER?
Previous project not enabled for it. LTR may cause device lose when suspend/resume. Do we need AER, I think it okay to have it?
To view, visit change 49007. To unsubscribe, or for help writing mail filters, visit settings.