Felix Held submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
cbfstool: Avoid defining _XOPEN_SOURCE

This restricts availability of non-standard functions (such as memmem)
on FreeBSD and macOS. It also isn't necessary on glibc.

Change-Id: Iaee1ce7304c89f128a35a385032fce16a2772b13
Signed-off-by: Alex James <theracermaster@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60232
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Julius Werner <jwerner@chromium.org>
---
M util/cbfstool/Makefile.inc
1 file changed, 0 insertions(+), 4 deletions(-)

diff --git a/util/cbfstool/Makefile.inc b/util/cbfstool/Makefile.inc
index 4651f51..3787a56 100644
--- a/util/cbfstool/Makefile.inc
+++ b/util/cbfstool/Makefile.inc
@@ -134,10 +134,6 @@
TOOLLDFLAGS ?=
HOSTCFLAGS += -fms-extensions

-ifneq ($(shell uname -o 2>/dev/null), FreeBSD)
-TOOLCPPFLAGS += -D_XOPEN_SOURCE=700 # strdup() from string.h
-endif
-
ifeq ($(shell uname -s | cut -c-7 2>/dev/null), MINGW32)
TOOLCFLAGS += -mno-ms-bitfields
endif

3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.

To view, visit change 60232. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaee1ce7304c89f128a35a385032fce16a2772b13
Gerrit-Change-Number: 60232
Gerrit-PatchSet: 5
Gerrit-Owner: Alex James <theracermaster@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Patrick Georgi <patrick@coreboot.org>
Gerrit-MessageType: merged