>>>>> Only remaining option is to use coreboot's ssdt generator.
>>>>
>>>> Or test _STA method proper.
>>>
>>> _STA is against the ACPI spec in case of PCI device. i don't
>>> understand whats the point of pushing in that line ?
>>
>> Because I couldn't find anything in ACPI spec telling that. Can
>> you point me to the specific paragraph, please?
>
> I thought you read entire gerrit discussion's for this CL.
>
> I have replied the same in Jan 10th that.
>
> src/soc/intel/cannonlake/acpi/scs.asl
> Line 30:
> . For _HID devices, OSPM evaluates the _STA method. For _ADR
> devices, OSPM checks with the bus driver for that device

That's your comment, we have been there.


https://www.uefi.org/sites/default/files/resources/ACPI_6.0.pdf
section 6.3.3

Section 6.3.3 is about an eject method. Also, 6.3.7 which is
about _STA doesn't talk about HID vs PCI devices. I've already
looked into the spec and the acpica implementation and have
failed to find any hint regarding this. If you really want to
help me, I'd need a very specific pointer or a quote of the
spec.

View Change

To view, visit change 30614. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90c0230e845c8d02386b50b1100faf7064ecf8f6
Gerrit-Change-Number: 30614
Gerrit-PatchSet: 3
Gerrit-Owner: V Sowmya <v.sowmya@intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan@intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 28 Jan 2019 14:11:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment