Attention is currently required from: Uwe Poeche, Werner Zeh, Jan Samek.

View Change

4 comments:

• Patchset:

  • Patch Set #9:

    A few thoughts. Feel free to say no, or to do changes in a follow-on patch - up to you.

• File src/mainboard/siemens/mc_ehl/variants/mc_ehl3/devicetree.cb:

  • Patch Set #9, Line 170:

    # Add dummy I2C device to limit BUS speed to 100 kHz in OS
    			chip drivers/i2c/generic
    				register "hid" = ""PRP0001""
    				register "speed" = "I2C_SPEED_STANDARD"
    				device i2c 0x7f on end
    			end
    

    Is this still needed with the addition of the new chip?

• File src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c:

  • Patch Set #9, Line 34: 6

    Nit: Can this be turned into a #define?

  • Patch Set #9, Line 39: @return -1 on error;

    Nit: Any reason not to use enum cb_err? It seems like it's basically returning success/failure.

To view, visit change 70692. To unsubscribe, or for help writing mail filters, visit settings.