Caveh Jalali uploaded patch set #2 to this change.

View Change

soc/intel/skylake: Use PCI func0 if enabled in device tree

Originally, if a devfn0 device was physically present, it would be
swapped with the next enabled device from the device tree. This would
result in the WiFi chip not showing up in ACPI SSDT. We should check
to see if the original device is enabled in the device tree before
looking for the next device to swap into its place.

BUG=b:122327852
TEST=the WiFi chip ACPI wake resource is now present SSDT:

Scope (\_SB.PCI0.RP01)
{
Device (WIFI)
{
Name (_UID, Zero) // _UID: Unique ID
Name (_DDN, "Intel WiFi") // _DDN: DOS Device Name
Name (_ADR, 0x00000000) // _ADR: Address
Name (_PRW, Package (0x02) // _PRW: Power Resources for Wake
{
0x27,
0x03
})
}
}

localhost ~ # cat /proc/acpi/wakeup
Device S-state Status Sysfs node
...
WIFI S3 *disabled pci:0000:01:00.0
...
localhost ~ #

Change-Id: I7c44ee5493eff1f9e04aa891030fde2a6f0c636f
Signed-off-by: Caveh Jalali <caveh@chromium.org>
---
M src/soc/intel/skylake/chip_fsp20.c
1 file changed, 7 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/32846/2

To view, visit change 32846. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c44ee5493eff1f9e04aa891030fde2a6f0c636f
Gerrit-Change-Number: 32846
Gerrit-PatchSet: 2
Gerrit-Owner: Caveh Jalali <caveh@google.com>
Gerrit-Reviewer: Caveh Jalali <caveh@google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai@intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: caveh jalali <caveh@chromium.org>
Gerrit-MessageType: newpatchset