5 comments:
Add a weak function mainboard_rtc_failed()
for mainboard customization.
Check RTC_PWR_STS bit for RTC battery removal
or CMOS clear jumper triggered event.
Please re-flow for 75 characters per line.
Done
File src/soc/intel/xeon_sp/include/soc/pmc.h:
nit: two spaces here (it's a bit inside a register)
Done
File src/soc/intel/xeon_sp/pmutil.c:
bool
Just follow declaration of weak function.
Patch Set #3, Line 16: PCH_DEVFN_PMC<<12
huh? Why this shift?
Done
Patch Set #3, Line 16: RTC_BATTERY_DEAD
Instead of masking here, I'd read the register as-is inside a variable and mask the desired bit else […]
Done
To view, visit change 43004. To unsubscribe, or for help writing mail filters, visit settings.