6 comments:
Patch Set #3, Line 7: skl,icl,cnl
I don't see apl in here. Is that intentional? What is your plan on enabling platforms other than big core? Do they fit into this model?
File src/soc/intel/common/basecode/bootblock/Kconfig:
Is that true?
File src/soc/intel/common/basecode/bootblock/bootblock.c:
Patch Set #3, Line 18: soc/bootblock.h
So, every SoC is expected to provide the declarations for the functions?
Patch Set #3, Line 19: soc/pch.h
Why is this included?
If a new platform decides to use this functionality, what are the functions that it is expected to provide? It is not clear at all from this change what is used from common/block and what is expected to be provided by SoC.
Patch Set #3, Line 30: bootblock_pch_early_init
This assumes that CONFIG_SOC_INTEL_COMMON_BLOCK_SA is selected by the SoC. Do you plan to auto select that based on the config selection? Similarly, whats the plan for other CONFIG_* that are assumed to be selected?
To view, visit change 35277. To unsubscribe, or for help writing mail filters, visit settings.