Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph, Karthik Ramasubramanian.

View Change

2 comments:

• File src/soc/intel/common/block/gpio/gpio.c:

  • Patch Set #3, Line 473:

    Nit: Extra line can be removed.

    Done

  • Patch Set #3, Line 561: int gpio_lock_pad(const gpio_t pad, enum gpio_lock_action action)

    Can the function body be replaced as: […]

    It won't be quite as efficient as calling gpio_lock_pad directly, but it does avoid duplicated logic and save some source code space. Done.

To view, visit change 58351. To unsubscribe, or for help writing mail filters, visit settings.