Attention is currently required from: Paul Menzel, Arthur Heymans, Patrick Rudolph, HAOUAS Elyes.

View Change

3 comments:

• Commit Message:

  • Patch Set #7, Line 7: northbridge/intel/i945: Prepare for x86_64

    This should state what the change does and not why. For instance,

        nb/intel/i945: Change types to uintptr_t where approriate

        Prepares compilation for x86_64 by avoiding casts to different sizes.

• File src/northbridge/intel/i945/gma.c:

  • Patch Set #7, Line 97: %lx

    %p implies a format (seems in our implementation that's 0x prefix and 8 chars
    width). Please maintain it, e.g.

        0x%08lx

    Or just don't change these two lines, `%p` with `(void *)pgfx` is fine too
    (as long as `pgfx` is a `uintptr_t` or `unsigned long`).

  • Patch Set #7, Line 359: pgfx, hactive * vactive * 4);

    Same here.

To view, visit change 61117. To unsubscribe, or for help writing mail filters, visit settings.