Thanks for updating the default FSP and VGA BIOS paths. However, I think you should leave the IFD and microcode paths alone until we have paths within 3rdparty/blobs to use instead. Removing the options entirely will almost certainly break things.

Patch set 2:Code-Review -1

View Change

4 comments:

• Commit Message:

  • Patch Set #2, Line 7: src: Kconfig: Update config for default path

    This is too vague. How about:
    baytrail/rangeley: Update paths for FSP_FILE and VGA_BIOS_BIN

• File src/cpu/intel/fsp_model_406dx/Kconfig:

  • Patch Set #2, Line 62:

    This will likely break things for users of this CPU. Please add the microcode header files to 3rdparty/blobs/cpu/intel/model_406dx/ and point there instead of removing this option.

• File src/soc/intel/fsp_baytrail/Kconfig:

  • Patch Set #2, Line 104:

    Please add the microcode headers to 3rdparty/blobs/soc/intel/baytrail/ instead of removing this option all together.

• File src/southbridge/intel/fsp_rangeley/Kconfig:

  • Patch Set #2, Line 51:

    This should probably be left alone until the mainboards which use Rangeley each have a default descriptor in 3rdparty/blobs/mainboard/

To view, visit change 34686. To unsubscribe, or for help writing mail filters, visit settings.