Patch Set #3, Line 14:
- The dead_code() macro causes linking errors, since dead functions
What exactly fails when you enable this? I took your patch, reverted the assert. […]
I recall having some problems with it early on, but I can't reproduce them anymore. (They might have been triggered by the partial linking, which caused all sorts of strange errors.) I've reverted it for now and Jenkins seems happy, so it looks like it's not an issue.
To view, visit change 38989. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Owner: Jacob Garber <email@example.com>
Gerrit-Reviewer: Jacob Garber <firstname.lastname@example.org>
Gerrit-Reviewer: Julius Werner <email@example.com>
Gerrit-Reviewer: Martin Roth <firstname.lastname@example.org>
Gerrit-Reviewer: Patrick Georgi <email@example.com>
Gerrit-Reviewer: Philipp Hug <firstname.lastname@example.org>
Gerrit-Reviewer: build bot (Jenkins) <email@example.com>
Gerrit-Reviewer: ron minnich <firstname.lastname@example.org>
Gerrit-CC: Paul Menzel <email@example.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 06:08:43 +0000
Comment-In-Reply-To: Julius Werner <firstname.lastname@example.org>