Attention is currently required from: Raul Rangel, Jeff Daly, Jonathan Zhang, Matt DeVillier, Julius Werner, Angel Pons, Arthur Heymans, Andrey Petrov, Lance Zhao, Jason Glenesk, Johnny Lin, Tim Wawrzynczak, Christian Walter, Vanessa Eusebio, Fred Reitberger, Elyes Haouas, Tim Chu, Felix Held.
I do not see what this patch aims to achieve. Casts are removed from platform code, but are introduced in common (src/lib/) code. CB:69078 makes sense to me, but this patch not so much.
Patch Set #5, Line 663:
(void *)cbmem_entry_start(to_be_updated) +
Patch Set #7, Line 112:
uintptr_t imd_entry_at(const struct imd *imd, const struct imd_entry *entry);
It should not be changed as it returns `pointer`. `uintptr_t` is not appropriate here.
Patch Set #7, Line 14:
uintptr_t relative_pointer(void *base, ssize_t offset)
I think it should remain `void *`. This function has `pointer` in it's name.
Patch Set #7, Line 267:
`(uintptr_t)` will be needed here after reverting above.
Patch Set #7, Line 568:
uintptr_t imd_entry_at(const struct imd *imd, const struct imd_entry *entry)
As in header file
Patch Set #7, Line 143:
uintptr_t cbmem_add(u32 id, u64 size)
This also should remain `void *`
To view, visit change 69163. To unsubscribe, or for help writing mail filters, visit settings.