View Change

3 comments:

• File src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb:

  • Patch Set #1, Line 52: register "FAN1.smart.full_lmt" = "0"

    Default for devicetree options is 0, so you can avoid having to add it everywhere 😊

    Thanks! I was unsure about that. Should we keep it anyway?

• File src/superio/ite/common/env_ctrl.c:

  • Patch Set #1, Line 151: ITE_EC_FAN_CTL_FULL_AT_THRML_LMT(conf->full_lmt));

    this overwrites what the function call in the lines above set. […]

    Ouch. The OR way sounds good. Thanks!

• File src/superio/ite/common/env_ctrl_chip.h:

  • Patch Set #1, Line 60: limit */

    that should fit all in one line; the characters per line limit was raised to 96 some time ago

    Done. The tmp_delta line could also be squeezed into 96 characters but then for aligning the */ on other lines they would be preceded by mixed tabs/spaces.

To view, visit change 44165. To unsubscribe, or for help writing mail filters, visit settings.