Martin L Roth submitted this change.

View Change

Approvals:
  build bot (Jenkins): Verified
  Martin L Roth: Looks good to me, approved

mb/starlabs/lite/glk: Don't configure GPIO's 147 through 156

These are configured by the TXE, so they do not need to be configured.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Change-Id: Ia1bf4e32aa156a0e1a74df2f62eb31cdadb376a9
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64454
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin L Roth <gaumless@tutanota.com>
---
M src/mainboard/starlabs/lite/variants/glk/gpio.c
1 file changed, 1 insertion(+), 24 deletions(-)

diff --git a/src/mainboard/starlabs/lite/variants/glk/gpio.c b/src/mainboard/starlabs/lite/variants/glk/gpio.c
index 5940571..f0d008c 100644
--- a/src/mainboard/starlabs/lite/variants/glk/gpio.c
+++ b/src/mainboard/starlabs/lite/variants/glk/gpio.c
@@ -322,42 +322,19 @@
 	PAD_NC(GPIO_145, DN_20K),
 	/* GPIO_146:	Not Connected		*/
 	PAD_NC(GPIO_146, DN_20K),
+	/* GPIO 147 through 156 are configured by the TXE */
 	/* GPIO_147:	LPC_SERIRQ		*/
-	_PAD_CFG_STRUCT(GPIO_147, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) |
-		PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K) | PAD_IOSTERM(ENPU)),
 	/* GPIO_148:	LPC_CLK0		*/
-	_PAD_CFG_STRUCT(GPIO_148, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) |
-		PAD_BUF(TX_RX_DISABLE), PAD_IOSSTATE(HIZCRx1)),
 	/* GPIO_149:	LPC_CLK_DBG_CPU		*/
-	_PAD_CFG_STRUCT(GPIO_149, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) |
-		PAD_BUF(TX_RX_DISABLE), PAD_IOSSTATE(HIZCRx1)),
 	/* GPIO_150:	LPC_AD0			*/
-	_PAD_CFG_STRUCT(GPIO_150, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) |
-		PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K) | PAD_IOSSTATE(HIZCRx1) |
-		PAD_IOSTERM(ENPU)),
 	/* GPIO_151:	LPC_AD1			*/
-	_PAD_CFG_STRUCT(GPIO_151, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) |
-		PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K) | PAD_IOSSTATE(HIZCRx1) |
-		PAD_IOSTERM(ENPU)),
 	/* GPIO_152:	LPC_AD2			*/
-	_PAD_CFG_STRUCT(GPIO_152, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) |
-		PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K) | PAD_IOSSTATE(HIZCRx1) |
-		PAD_IOSTERM(ENPU)),
 	/* GPIO_153:	LPC_AD3			*/
-	_PAD_CFG_STRUCT(GPIO_153, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) |
-		PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K) | PAD_IOSSTATE(HIZCRx1) |
-		PAD_IOSTERM(ENPU)),
 	/* GPIO_154:	LPC_CLKRUN#		*/
-	_PAD_CFG_STRUCT(GPIO_154, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) |
-		PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)),
 	/* GPIO_155:	LPC_FRAME#		*/
-	_PAD_CFG_STRUCT(GPIO_155, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) |
-		PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K) | PAD_IOSSTATE(HIZCRx1) |
-		PAD_IOSTERM(ENPU)),
 
 	/* ----- GPIO Group Audio ----- */
 	/* GPIO_156:	FP_INT#			*/
-	PAD_NC(GPIO_156, DN_20K),
 	/* GPIO_157:	Not Connected		*/
 	PAD_NC(GPIO_157, DN_20K),
 	/* GPIO_158:	Not Connected		*/

To view, visit change 64454. To unsubscribe, or for help writing mail filters, visit settings.