Attention is currently required from: Felix Singer, Fred Reitberger, Martin L Roth.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74480?usp=email )
Change subject: payloads: Add target to download depthcharge source
......................................................................
Patch Set 1:
(1 comment)
File payloads/external/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/74480/comment/2b3fe9bf_2be4cb9f :
PS1, Line 144: download-depthcharge:
: $(MAKE) -C payloads/external/depthcharge download_tag \
: MFLAGS= MAKEFLAGS= \
: DEPTHCHARGE_MASTER=$(CONFIG_DEPTHCHARGE_MASTER) \
: DEPTHCHARGE_STABLE=$(CONFIG_DEPTHCHARGE_STABLE) \
: DEPTHCHARGE_REVISION=$(CONFIG_DEPTHCHARGE_REVISION) \
: DEPTHCHARGE_REVISION_ID=$(CONFIG_DEPTHCHARGE_REVISION_ID)
can this be moved to the depthcharge makefile?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74480?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60bf04bbadccc1a0692958b17e2b66b7ad47a396
Gerrit-Change-Number: 74480
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Fri, 09 Jun 2023 17:56:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
