Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41881 )
Change subject: mb/google/dedede: Switch to using auto-generated SPDs
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41881/10/src/mainboard/google/deded...
File src/mainboard/google/dedede/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/41881/10/src/mainboard/google/deded...
PS10, Line 16: subdirs-y += spd
Couple more changes: […]
Aah that explains why it didn't fail earlier with the wrong name. Thanks for digging into this Karthik! I think we should be able to use GENERIC_SPD_BIN, but let's do that as follow-up.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41881
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6fadae0abcfb6e50d3cc502098ace9b668667a51
Gerrit-Change-Number: 41881
Gerrit-PatchSet: 11
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 03 Jun 2020 22:12:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment