Patch set 2:Code-Review +1
4 comments:
Please spell this out in the beginning (not in the third paragraph).
Currently it is impossible to enable ACS with AGESA by setting the correct
bit for AmdInitMid phase. AGESA code path does not call the right function
that enables these functionalities.
Can a comment be added to the code in question?
File src/northbridge/amd/pi/00730F01/northbridge.c:
E or B?
/* Enable ACS capabilities straps including sub-items. From lspci it
* looks like these bits enable: Source Validation and Translation
* Blocking
*/
Please use one of the listed styles from the coding style.
To view, visit change 35313. To unsubscribe, or for help writing mail filters, visit settings.