13 comments:
Patch Set #12, Line 7: drivers/intel/mipi_camera: camera SSDT generation
Please make it a statement by adding a verb (in imperative mood).
Generate SSDT for camera
Patch Set #12, Line 12: missing some properties needed for Linux drivers.
Please mention the properties.
Some boards & variants are using raw asl files to define the ACPI devices
(and related properties) required by Linux MIPI camera drivers.
The mipi_camera driver can provide a SSDB property, but it's
missing some properties needed for Linux drivers.
Please re-flow for 75 characters per line.
ASL
Please mention one difference.
File src/drivers/intel/mipi_camera/camera.c:
Patch Set #12, Line 42: uint32_t i, j;
Please use the native types `unsigned int` or `size_t`.
Patch Set #12, Line 607: prefix = "ERR"; /* Error */
Should a debug message be added for this case?
knows?
File src/drivers/intel/mipi_camera/chip.h:
Patch Set #12, Line 131: * General settings that can be used for any type (but doesn't
don’t?
Patch Set #12, Line 132: * necessarily need to be used/specified for each device.
Missing closing ).
Patch Set #12, Line 148: uint8_t num_freq_entries; /* # of elements in link_freq */
Please use native types.
Patch Set #12, Line 163: * you can use zero for a value.
Please re-flow for at least 80 characters per line (maybe even 96).
Patch Set #12, Line 167: uint32_t nvm_size;
Can native types be used here?
To view, visit change 41607. To unsubscribe, or for help writing mail filters, visit settings.