Attention is currently required from: Felix Singer, Raul Rangel, Furquan Shaikh, Paul Menzel, Angel Pons, Subrata Banik, Kyösti Mälkki, Patrick Rudolph, Jason Glenesk, Matt Delco, Nico Huber, Marshall Dawson, Tim Wawrzynczak, Felix Held.
109 comments:
File src/acpi/acpigen.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 1802: if (entry->type == CPPC_TYPE_DWORD) {
braces {} are not necessary for any arm of this statement
File src/cpu/intel/common/common_init.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 108: config->entries[CPPC_HIGHEST_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 0, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 108: config->entries[CPPC_HIGHEST_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 0, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 108: config->entries[CPPC_HIGHEST_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 0, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 109: config->entries[CPPC_NOMINAL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_PLATFORM_INFO, 8, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 109: config->entries[CPPC_NOMINAL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_PLATFORM_INFO, 8, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 109: config->entries[CPPC_NOMINAL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_PLATFORM_INFO, 8, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 110: config->entries[CPPC_LOWEST_NONL_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 16, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 110: config->entries[CPPC_LOWEST_NONL_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 16, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 110: config->entries[CPPC_LOWEST_NONL_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 16, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 111: config->entries[CPPC_LOWEST_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 24, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 111: config->entries[CPPC_LOWEST_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 24, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 111: config->entries[CPPC_LOWEST_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 24, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 112: config->entries[CPPC_GUARANTEED_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 8, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 112: config->entries[CPPC_GUARANTEED_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 8, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 112: config->entries[CPPC_GUARANTEED_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 8, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 113: config->entries[CPPC_DESIRED_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 16, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 113: config->entries[CPPC_DESIRED_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 16, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 113: config->entries[CPPC_DESIRED_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 16, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 114: config->entries[CPPC_MIN_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 0, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 114: config->entries[CPPC_MIN_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 0, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 114: config->entries[CPPC_MIN_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 0, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 115: config->entries[CPPC_MAX_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 8, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 115: config->entries[CPPC_MAX_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 8, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 115: config->entries[CPPC_MAX_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 8, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 116: config->entries[CPPC_PERF_REDUCE_TOLERANCE] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 116: config->entries[CPPC_PERF_REDUCE_TOLERANCE] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 117: config->entries[CPPC_TIME_WINDOW] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 117: config->entries[CPPC_TIME_WINDOW] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 118: config->entries[CPPC_COUNTER_WRAP] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 118: config->entries[CPPC_COUNTER_WRAP] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 119: config->entries[CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(IA32_MPERF, 0, 64) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 119: config->entries[CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(IA32_MPERF, 0, 64) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 119: config->entries[CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(IA32_MPERF, 0, 64) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 120: config->entries[CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(IA32_APERF, 0, 64) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 120: config->entries[CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(IA32_APERF, 0, 64) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 120: config->entries[CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(IA32_APERF, 0, 64) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 121: config->entries[CPPC_PERF_LIMITED] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_STATUS, 2, 1) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 121: config->entries[CPPC_PERF_LIMITED] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_STATUS, 2, 1) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 121: config->entries[CPPC_PERF_LIMITED] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_STATUS, 2, 1) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 122: config->entries[CPPC_ENABLE] = CPPC_REG( ACPI_REG_MSR(IA32_PM_ENABLE, 0, 1) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 122: config->entries[CPPC_ENABLE] = CPPC_REG( ACPI_REG_MSR(IA32_PM_ENABLE, 0, 1) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 122: config->entries[CPPC_ENABLE] = CPPC_REG( ACPI_REG_MSR(IA32_PM_ENABLE, 0, 1) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 128: config->entries[CPPC_AUTO_ACTIVITY_WINDOW] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 32, 10) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 128: config->entries[CPPC_AUTO_ACTIVITY_WINDOW] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 32, 10) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 128: config->entries[CPPC_AUTO_ACTIVITY_WINDOW] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 32, 10) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 129: config->entries[CPPC_PERF_PREF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 24, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 129: config->entries[CPPC_PERF_PREF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 24, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 129: config->entries[CPPC_PERF_PREF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 24, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 130: config->entries[CPPC_REF_PERF] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 130: config->entries[CPPC_REF_PERF] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 135: config->entries[CPPC_LOWEST_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 135: config->entries[CPPC_LOWEST_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 136: config->entries[CPPC_NOMINAL_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 136: config->entries[CPPC_NOMINAL_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
File src/soc/amd/cezanne/cppc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 18: config->entries[CPPC_HIGHEST_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_HIGHEST_PERF, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 18: config->entries[CPPC_HIGHEST_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_HIGHEST_PERF, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 18: config->entries[CPPC_HIGHEST_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_HIGHEST_PERF, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 19: config->entries[CPPC_NOMINAL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_NOMINAL_PERF, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 19: config->entries[CPPC_NOMINAL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_NOMINAL_PERF, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 19: config->entries[CPPC_NOMINAL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_NOMINAL_PERF, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 20: config->entries[CPPC_LOWEST_NONL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOW_NON_LIN_PERF, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 20: config->entries[CPPC_LOWEST_NONL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOW_NON_LIN_PERF, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 20: config->entries[CPPC_LOWEST_NONL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOW_NON_LIN_PERF, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 21: config->entries[CPPC_LOWEST_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOWEST_PERF, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 21: config->entries[CPPC_LOWEST_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOWEST_PERF, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 21: config->entries[CPPC_LOWEST_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOWEST_PERF, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 22: config->entries[CPPC_GUARANTEED_PERF] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 22: config->entries[CPPC_GUARANTEED_PERF] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 23: config->entries[CPPC_DESIRED_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_DES_PERF, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 23: config->entries[CPPC_DESIRED_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_DES_PERF, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 23: config->entries[CPPC_DESIRED_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_DES_PERF, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 24: config->entries[CPPC_MIN_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MIN_PERF, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 24: config->entries[CPPC_MIN_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MIN_PERF, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 24: config->entries[CPPC_MIN_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MIN_PERF, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 25: config->entries[CPPC_MAX_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MAX_PERF, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 25: config->entries[CPPC_MAX_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MAX_PERF, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 25: config->entries[CPPC_MAX_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MAX_PERF, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 26: config->entries[CPPC_PERF_REDUCE_TOLERANCE] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 26: config->entries[CPPC_PERF_REDUCE_TOLERANCE] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 27: config->entries[CPPC_TIME_WINDOW] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 27: config->entries[CPPC_TIME_WINDOW] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 28: config->entries[CPPC_COUNTER_WRAP] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 28: config->entries[CPPC_COUNTER_WRAP] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 29: config->entries[CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_MAX_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 29: config->entries[CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_MAX_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 29: config->entries[CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_MAX_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 30: config->entries[CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_ACTUAL_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 30: config->entries[CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_ACTUAL_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 30: config->entries[CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_ACTUAL_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 31: config->entries[CPPC_PERF_LIMITED] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_STATUS, 1, 1) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 31: config->entries[CPPC_PERF_LIMITED] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_STATUS, 1, 1) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 31: config->entries[CPPC_PERF_LIMITED] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_STATUS, 1, 1) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 32: config->entries[CPPC_ENABLE] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_ENABLE, 0, 1) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 32: config->entries[CPPC_ENABLE] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_ENABLE, 0, 1) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 32: config->entries[CPPC_ENABLE] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_ENABLE, 0, 1) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 37: config->entries[CPPC_AUTO_SELECT] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 37: config->entries[CPPC_AUTO_SELECT] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 38: config->entries[CPPC_AUTO_ACTIVITY_WINDOW] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 38: config->entries[CPPC_AUTO_ACTIVITY_WINDOW] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 39: config->entries[CPPC_PERF_PREF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_ENERGY_PERF_PREF, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 39: config->entries[CPPC_PERF_PREF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_ENERGY_PERF_PREF, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 39: config->entries[CPPC_PERF_PREF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_ENERGY_PERF_PREF, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 40: config->entries[CPPC_REF_PERF] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 40: config->entries[CPPC_REF_PERF] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 45: config->entries[CPPC_LOWEST_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 45: config->entries[CPPC_LOWEST_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 46: config->entries[CPPC_NOMINAL_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826):
Patch Set #5, Line 46: config->entries[CPPC_NOMINAL_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
To view, visit change 57886. To unsubscribe, or for help writing mail filters, visit settings.