Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47684 )
Change subject: soc/tigerlake: Update early TCSS code to not call back and forth between mainboard and soc ......................................................................
Patch Set 4:
(6 comments)
File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/47684/comment/7ea58017_70729eb8 PS1, Line 281:
extra line
Done
https://review.coreboot.org/c/coreboot/+/47684/comment/84122912_098f4e57 PS1, Line 286: system_requires_early_display
You can replace this with if (!display_init_required()). […]
Done
File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/47684/comment/6fcaad20_c567716b PS2, Line 286: system_requires_early_display
I don't think this is addressed in latest patchset?
Oops I added this to the next patch instead of this one I'll move it to this one if that matters
https://review.coreboot.org/c/coreboot/+/47684/comment/d64bbb20_aaa09ce4 PS2, Line 296: __weak
If mainboard selects the respective Kconfig, it should implement the required callback. […]
wouldn't the build fail if EARLY_TCSS_DISPLAY is not selected but EARLY_TCSS is without weak functions?
File src/soc/intel/tigerlake/include/soc/early_tcss.h:
https://review.coreboot.org/c/coreboot/+/47684/comment/0c802f69_22281570 PS1, Line 129: //void update_tcss_mux(int port, struct tcss_mux mux_data);
Drop this instead of commenting.
Done
https://review.coreboot.org/c/coreboot/+/47684/comment/c96e3c75_a13cbe86 PS1, Line 141: mainboard_early_tcss_enable
Yeah I think both of those should work fine I'll change this up to do that.
Done