Patch Set 2: Code-Review-1

configs must contain defconfigs.
configs is used by jenkins for additional non default board builds.

Even if I would convert this config to defconfig, Jenkins would still fail because it does not have the AtomBIOS ROM which this config is using. Initially I was confused about the purpose of ./configs/ , and now understand that this commit is incorrect - but still would like to provide an example config here besides at the board_status.

View Change

To view, visit change 33800. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide7529762813944b4f91b2ee8b3ef327b5daffc4
Gerrit-Change-Number: 33800
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Banon <>
Gerrit-Reviewer: Mike Banon <>
Gerrit-Reviewer: Patrick Rudolph <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Paul Menzel <>
Gerrit-Comment-Date: Sun, 14 Jul 2019 10:09:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment