Attention is currently required from: Christian Walter, Julius Werner, Jérémy Compostella, Krystian Hebel, Martin L Roth, Sergii Dmytruk.
1 comment:
File src/drivers/pc80/tpm/tis.c:
Patch Set #24, Line 389: return TPM_SUCCESS; /* Already probed. */
Here you have to return the family, otherwise `*family` checks will fail if pc80_tis_probe is called multiple times.
I have a used case for pc80_tis_probe where it will be needed to be called at least twice in ramstage.
I suggest a static variable in this function to hold the detected TPM family and return it if the TPM was probed already (and the argument is not NULL).
To view, visit change 69159. To unsubscribe, or for help writing mail filters, visit settings.