Attention is currently required from: Arthur Heymans, Benjamin Doron, David Milosevic, Julius Werner, Marvin Drees, Maximilian Brune, Paul Menzel.

View Change

1 comment:

• File src/arch/arm64/armv8/cache.c:

  • Patch Set #12, Line 61: ccsidr_el1 = raw_read_ccsidr_el1();

    why remove it. […]

    Agreed. If anything, I'm OK with declaring the variable and initializing it on a single line. You can even use `const` to better show this variable is not modified:

    ```
    const uint64_t ccsidr_el1 = raw_read_ccsidr_el1();
    ```

To view, visit change 79106. To unsubscribe, or for help writing mail filters, visit settings.