Attention is currently required from: Alper Nebi Yasak.
1 comment:
File src/mainboard/emulation/qemu-aarch64/cbmem.c:
Patch Set #2, Line 12: top = fdt_get_memory_top((void *)_dram);
On all the other Arm devices we've followed the example from x86 to use `((uintptr_t)4 * GiB)` as cbmem_top if the physical DRAM goes beyond that point. There's no real reason to put CBMEM exactly at the end, it just needs to be high enough to have room to grow downwards. Since most of coreboot was originally designed for x86_32 we thought it would be better this way so that we'll never have any pointers go over the 32-bit limit, just in case there still is some old code that makes incorrect pointer size assumptions somewhere that we have overlooked.
To view, visit change 80364. To unsubscribe, or for help writing mail filters, visit settings.