12 comments:
File Documentation/mainboard/libretrend/lt1000.jpg:
This image is a bit too grainy for its size. Any better options?
File Documentation/mainboard/libretrend/lt1000.md:
Patch Set #13, Line 60: LVDS header
It's not going to work with libgfxinit, though. It's disabled.
Patch Set #13, Line 61: onboard
Capitalize this: "Onboard"
Patch Set #13, Line 102: Super I/O, EC
Is it both?
File src/mainboard/libretrend/lt1000/acpi/ec.asl:
can be dropped?
I think this file must be here.
File src/mainboard/libretrend/lt1000/acpi_tables.c:
pretty sure this can be dropped
Definitely.
File src/mainboard/libretrend/lt1000/devicetree.cb:
There's an enum for this
File src/mainboard/libretrend/lt1000/dsdt.asl:
Patch Set #13, Line 28: // Some generic macros
This comment got dropped
Patch Set #13, Line 34: // CPU
This comment is not useful
Scope (\_SB) {
Device (PCI0)
Device (\_SB.PCI0)
Patch Set #13, Line 45: // Chipset specific sleep states
This got dropped as well.
File src/mainboard/libretrend/lt1000/romstage.c:
Patch Set #3, Line 26: #include <console/console.h>
not used? […]
Done
To view, visit change 30360. To unsubscribe, or for help writing mail filters, visit settings.