Subrata Banik submitted this change.

View Change

Approvals: build bot (Jenkins): Verified V Sowmya: Looks good to me, approved Angel Pons: Looks good to me, approved
mb/intel/adlrvp: Refactor lpddr4_mem_config structure

List of changes:
1. Initialize dq_map array in a single line
2. Make dqs_map array also in a single line

TEST=Able to build and boot ADLRVP LP4 SKU.

Change-Id: I64f2b38492934c8ede301f4b252c8700060ed4ac
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48077
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: V Sowmya <v.sowmya@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/intel/adlrvp/memory.c
1 file changed, 9 insertions(+), 19 deletions(-)

diff --git a/src/mainboard/intel/adlrvp/memory.c b/src/mainboard/intel/adlrvp/memory.c
index 5d374db..b203f69 100644
--- a/src/mainboard/intel/adlrvp/memory.c
+++ b/src/mainboard/intel/adlrvp/memory.c
@@ -22,29 +22,19 @@
static const struct mb_cfg lpddr4_mem_config = {
/* DQ byte map */
.dq_map = {
- { 0, 2, 3, 1, 6, 7, 5, 4, /* Byte 0 */
- 10, 8, 11, 9, 14, 12, 13, 15 }, /* Byte 1 */
- { 12, 8, 14, 10, 11, 13, 15, 9, /* Byte 2 */
- 5, 0, 7, 3, 6, 2, 1, 4 }, /* Byte 3 */
- { 3, 0, 2, 1, 6, 5, 4, 7, /* Byte 4 */
- 12, 13, 14, 15, 10, 9, 8, 11 }, /* Byte 5 */
- { 2, 6, 7, 1, 3, 4, 0, 5, /* Byte 6 */
- 9, 13, 8, 15, 14, 11, 12, 10 }, /* Byte 7 */
- { 3, 0, 1, 2, 7, 4, 6, 5, /* Byte 0 */
- 10, 8, 11, 9, 14, 13, 12, 15 }, /* Byte 1 */
- { 10, 12, 14, 8, 9, 13, 15, 11, /* Byte 2 */
- 3, 7, 6, 2, 0, 4, 5, 1 }, /* Byte 3 */
- { 12, 15, 14, 13, 9, 10, 11, 8, /* Byte 4 */
- 7, 4, 6, 5, 0, 1, 3, 2 }, /* Byte 5 */
- { 0, 2, 4, 3, 1, 6, 7, 5, /* Byte 6 */
- 13, 9, 10, 11, 8, 12, 14, 15 }, /* Byte 7 */
+ { 0, 2, 3, 1, 6, 7, 5, 4, 10, 8, 11, 9, 14, 12, 13, 15 },
+ { 12, 8, 14, 10, 11, 13, 15, 9, 5, 0, 7, 3, 6, 2, 1, 4 },
+ { 3, 0, 2, 1, 6, 5, 4, 7, 12, 13, 14, 15, 10, 9, 8, 11 },
+ { 2, 6, 7, 1, 3, 4, 0, 5, 9, 13, 8, 15, 14, 11, 12, 10 },
+ { 3, 0, 1, 2, 7, 4, 6, 5, 10, 8, 11, 9, 14, 13, 12, 15 },
+ { 10, 12, 14, 8, 9, 13, 15, 11, 3, 7, 6, 2, 0, 4, 5, 1 },
+ { 12, 15, 14, 13, 9, 10, 11, 8, 7, 4, 6, 5, 0, 1, 3, 2 },
+ { 0, 2, 4, 3, 1, 6, 7, 5, 13, 9, 10, 11, 8, 12, 14, 15 },
},

/* DQS CPU<>DRAM map */
.dqs_map = {
- /* Ch 0 1 2 3 */
- { 0, 1 }, { 1, 0 }, { 0, 1 }, { 0, 1 },
- { 0, 1 }, { 1, 0 }, { 1, 0 }, { 0, 1 }
+ { 0, 1 }, { 1, 0 }, { 0, 1 }, { 0, 1 }, { 0, 1 }, { 1, 0 }, { 1, 0 }, { 0, 1 }
},

.dq_pins_interleaved = false,

To view, visit change 48077. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64f2b38492934c8ede301f4b252c8700060ed4ac
Gerrit-Change-Number: 48077
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath@intel.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla@intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: V Sowmya <v.sowmya@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged