Patch set 3:Code-Review +2
4 comments:
File src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c:
/* GPP_B0 - Reserved */
PAD_NC(GPP_B0, NONE),
/* GPP_B1 - Reserved */
PAD_NC(GPP_B1, NONE),
Looking again, these two should have a pull, or can be left as native functions.
Done
/* GPP_D13 - GPIO */
PAD_NC(GPP_D13, NONE),
/* GPP_D14 - GPIO */
PAD_CFG_GPO(GPP_D14, 1, PLTRST),
Both of these are unused, and should have a pull (down, 20k)
Done
/* GPP_H6 - I2C3_SDA */
PAD_NC(GPP_H6, NONE),
/* GPP_H7 - I2C3_SCL */
PAD_NC(GPP_H7, NONE),
/* GPP_H8 - I2C4_SDA */
PAD_NC(GPP_H8, NONE),
/* GPP_H9 - I2C4_SCL */
PAD_NC(GPP_H9, NONE),
These are floating and should use a pull (up, 20k).
Done
/* GPP_H12 - GPIO */
PAD_CFG_GPO(GPP_H12, 1, PLTRST),
/* GPP_H13 - GPIO */
PAD_CFG_GPO(GPP_H13, 1, PLTRST),
/* GPP_H14 - GPIO */
PAD_NC(GPP_H14, NONE),
/* GPP_H15 - GPIO */
PAD_CFG_GPO(GPP_H15, 1, PLTRST),
/* GPP_H16 - GPIO */
PAD_NC(GPP_H16, NONE),
/* GPP_H17 - GPIO */
PAD_NC(GPP_H17, NONE),
These are floating and should use a pull (up, 20k).
Done
To view, visit change 47191. To unsubscribe, or for help writing mail filters, visit settings.