Attention is currently required from: Keith Hui, Keith Hui, Paul Menzel.
Fabian Groffen has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/coreboot/+/75137?usp=email )
Change subject: mb/asus/p8z77-m: Remove settings to replicate OEM ......................................................................
Patch Set 6: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75137/comment/d8084662_dafb80a2?usp... : PS6, Line 9: Per Fabian: : : With these settings enabled COM 1/UART A/serial port 1 gets blocked : right after the kernel boots. It no longer works or responds, which : actually means the Linux boot process gets stuck forever when configured : to write to ttyS0. : : Not using these settings, I have not found any downside. Serial keeps : working, sensors still work, S3 suspend/resume works correctly. : : --- : : Out of the six settings in this group, three are causing the initial : issue, the rest are confirmed necessary to be replicated, with PECI : as the reason for one of them. Keith revised this patch to reflect : this.
Understood. […]
For what it's worth, I hereby grant permission to rework/rename/redescribe this commit in any way including removing my authorship or signoff. I think it's clear I did some work that seemed to work for me, but that Keith did a lot more work that is sound and reasonable. I think it would improve coreboot if his variant of the work would get merged.
Thanks, Fabian