Attention is currently required from: Johnny Lin, Christian Walter, Arthur Heymans, Elyes Haouas, Tim Chu.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71140 )
Change subject: soc/intel/xeon_sp/Kconfig: select configs for skx/cpx
......................................................................
Patch Set 1:
(4 comments)
File src/soc/intel/xeon_sp/Kconfig:
https://review.coreboot.org/c/coreboot/+/71140/comment/9f0271e7_94765866
PS1, Line 26: CPU_INTEL_COMMON_SMM
this is already selected here src/cpu/intel/common/Kconfig: […]
Done
https://review.coreboot.org/c/coreboot/+/71140/comment/1e8f4273_b56c2d3d
PS1, Line 27: SOC_INTEL_COMMON_BLOCK_SMM
see line #62
Done
https://review.coreboot.org/c/coreboot/+/71140/comment/eb324117_b486274a
PS1, Line 28: HAVE_SMI_HANDLER
line #46
Done
https://review.coreboot.org/c/coreboot/+/71140/comment/2f9bfb62_b9016e96
PS1, Line 29: NO_FSP_TEMP_RAM_EXIT
line #49
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71140
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3256c3c6a4ea331efae00d78192355a1fd78d6d2
Gerrit-Change-Number: 71140
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 06 Jan 2023 22:40:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment