Attention is currently required from: Arthur Heymans, Kyösti Mälkki.
Patch set 8:Code-Review +1
5 comments:
File src/arch/x86/cpu.c:
Patch Set #5, Line 224: return NULL;
Given the usage below, maybe it's best to die instead of returning NULL? How important is the CPU cluster device?
Patch Set #5, Line 233: cpu_cluster()
Can return NULL
Patch Set #5, Line 254: return dev->path.apic.initial_lapicid;
When there are `N` CPU devices (`0` to `N - 1`) and one calls this function with `N` as `logical_cpu`, `dev` would be NULL.
File src/cpu/x86/lapic/lapic_cpu_init.c:
Patch Set #8, Line 255: cpu_add_map_entry(info->index);
Where is `initial_lapicid` set?
Patch Set #8, Line 396: cpu_add_map_entry(info->index);
Where is `initial_lapicid` set?
To view, visit change 64342. To unsubscribe, or for help writing mail filters, visit settings.