Attention is currently required from: Erik van den Bogaert, Felix Singer, Frans Hendriks, Jonathon Hall, Michał Żygowski, Piotr Król.
View Change
1 comment:
Patchset:
Patch Set #6:
Then how do people review this patch pretending that all devicetrees have been checked
We don't have to pretend anything. On EHL, I just checked them. Fair enough, on SKL there's more of them so it's not *that* easy.
They need to go through all .cb files from that platform and compare the option with the devicetree.
Exactly - I have seen this as one-time effort not worth automation. But I don't want to not stand in your way.
To view, visit change 79958. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I397497118d6868e4a6d4086e97901081da7d5fda
Gerrit-Change-Number: 79958
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert@eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall@puri.sm>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Piotr Król <piotr.krol@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Jan Samek <jan.samek@siemens.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Attention: Erik van den Bogaert <ebogaert@eltan.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Attention: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Attention: Jonathon Hall <jonathon.hall@puri.sm>
Gerrit-Attention: Piotr Król <piotr.krol@3mdeb.com>
Gerrit-Comment-Date: Fri, 19 Jan 2024 08:41:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Comment-In-Reply-To: Jan Samek <jan.samek@siemens.com>
Gerrit-MessageType: comment