4 comments:
File src/drivers/spi/tpm/Kconfig:
Patch Set #2, Line 21: Board has SPI TPM support
nit: should say something different from the one below
File src/drivers/spi/tpm/tpm.c:
Patch Set #2, Line 198: SPI transfer error\n
nit: Mention something about this being in the TPM driver?
Patch Set #2, Line 203: !CONFIG(TPM_CR50) && (
CONFIG() test is unnecessary here.
File src/security/tpm/Kconfig:
Patch Set #1, Line 29: || MAINBOARD_HAS_SPI_TPM_CR50 || MAINBOARD_HAS_CRB_TPM \
Well, I don't understand why everything is aligned after "MAINBOARD_HAS_I2C_TPM_GENERIC". […]
I think the intention is still that Kconfig files adhere to the usual 80 (or now 96) character limit. Of course, they're currently probably not all compliant with that...
I agree that this looks odd and aligning after "depends on " would probably be better.
To view, visit change 39693. To unsubscribe, or for help writing mail filters, visit settings.