Is the name hibrid_romstage going to be final? I remember some discussions about using some different name. If so, shouldn't you change file name and the commit message?>
3 comments:
File src/soc/amd/picasso/early_stack.S:
Extra space.
Patch Set #13, Line 32: * may be enabled. This could be made more elegant for more
Current limit is 96 columns, please use full new size. Same in next comment.
File src/soc/amd/picasso/hybrid_romstage.c:
Patch Set #13, Line 4: * Copyright (C) 2019 Advanced Micro Devices, Inc.
In romstage.h you placed this line after previous copyright, here you placed it before. Examining other code, it looks like placing newer copyrights after older copyrights is the norm. Please change order.
To view, visit change 33759. To unsubscribe, or for help writing mail filters, visit settings.