Attention is currently required from: Felix Singer, Maxim Polyakov, Angel Pons.
View Change
2 comments:
Commit Message:
Patch Set #4, Line 16: Finish the overridetree
There's no way to tell what should go into devicetree.cb and what should go into overridetree. […]
Would it make sense to rather not define a global devicetree and overridetrees for the variants but rather define an independant devicetree for each variant?
Commit Message:
Patch Set #9, Line 13: - Correct UART Output (Output seems to have wrong BAUD,
Would it be helpful to provide the garbled output via a pastebin? Otherwise I could also provide the console output via the SPI flash dump. I'm also working with the datasheet of a slightly different
chip as the NCT5539D one isn't available to me.
To view, visit change 48648. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab30596f2a12931679687c9f56427712b65f9363
Gerrit-Change-Number: 48648
Gerrit-PatchSet: 9
Gerrit-Owner: Marvin Drees
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Wed, 03 Feb 2021 18:29:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment