View Change
1 comment:
Commit Message:
Patch Set #3, Line 7: asus/p2b-*: Fold into p2b as variants thereof
Could you please split this out, so that each change only folds one mainboard? It would make it easier to review. You can use [1] as an example.
Also, if you align the various boards carefully, you can use BUILD_TIMELESS to ensure the binaries do not change at all.
[1]: https://review.coreboot.org/q/topic:"unify_hp_laptops"
To view, visit change 38621. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc9bfa4fc5b582bf658215bda298523e8ee7b36b
Gerrit-Change-Number: 38621
Gerrit-PatchSet: 3
Gerrit-Owner: Keith Hui <buurin@gmail.com>
Gerrit-Reviewer: Keith Hui <buurin@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Sun, 02 Feb 2020 12:32:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment