Patch Set #9, Line 8:
Why not put this inside a smbus_methods.asl in common code and include it if desired? You can place the first part inside a `Scope (SBUS)` block for simplicity
// 0x00 : OK
// 0x07 : Unknown Failure
// 0x10 : Address Not Acknowledged
// 0x11 : Device Error
// 0x12 : Command Access Denied
// 0x13 : Unknown Error
// 0x17 : Device Access Denied
// 0x18 : Timeout
// 0x19 : Unsupported Protocol
// 0x1A : Bus Busy
// 0x1F : PEC (CRC-8) Error
Use #defines for these?
Patch Set #9, Line 82:
// Transaction isn't complete. Check for timeout, and if not, sleep 10ms and
line over 96 characters. Please try to split this into two parts of about the same length.
Does using hex make this easier to read?
Patch Set #9, Line 145:
If ((Arg0 != 0x03)) // Read Quick
Command codes should really be #defined somewhere. Also, this would be better done within the first switch-case like block inside the mutex acquired section.
they (command code and data length)
Patch Set #9, Line 208:
If ((Arg0 != 0x02)) // Write Quick
If ((Arg0 != 0x04)) // Send Byte
If ((Arg0 != 0x06)) // Write Byte
If ((Arg0 != 0x08)) // Write Word
If ((Arg0 != 0x0A)) // Write Block
Local0 [Zero] = 0x19
Why not check this within the mutex section?
To view, visit change 44507. To unsubscribe, or for help writing mail filters, visit settings.