Patch Set 7:

Dear Furquan,

Default eMMC and PCI host controller is enable, so don't need configure them when sku id is 255. Because in the overridetree.cb under the Akmei, node pci 1a.0 point to eMMC and it is enable, In addition devicetree.cb under the baseboard, the PCI host controller default is enable. Please kindly review.

Thanks and best regards

PCI devices are enabled, but what about the GPIO configurations? Don't you need to ensure that the GPIOs are configured correctly too?

View Change

To view, visit change 35204. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I827e6f1420801d43e0eb4708b8b8ad1692ef7e9f
Gerrit-Change-Number: 35204
Gerrit-PatchSet: 7
Gerrit-Owner: Peichao Li <peichao.wang@bitland.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Marco Chen <marcochen@google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Peichao Li <peichao.wang@bitland.corp-partner.google.com>
Gerrit-Reviewer: Philip Chen <philipchen@google.com>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Guohui Zhou <guohui.zhou@bitland.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 11 Sep 2019 02:03:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment