7 comments:
Patch Set #3, Line 51: #define TIMESTAMP_CACHE_IN_BSS (ENV_RAMSTAGE || ENV_POSTCAR)
It's not an insurmountable problem, but I would prefer initializing timestamps in picasso before cbm […]
Ack
Patch Set #3, Line 94: ts_cache = (void *)_timestamp;
Can't use car_get_var_ptr() after _timestamp is moved outside _car_relocatable. Currently FSP1. […]
Done
Patch Set #3, Line 146: if (ts_table == NULL && HAS_CBMEM)
I don't think this would ever be hit?
Done
Patch Set #3, Line 224: ts_cache->cache_state != TIMESTAMP_CACHE_UNINITIALIZED)
nit: Somewhat tangential, but I think we could get rid of the whole cache_state thing if you just ch […]
Done
Patch Set #5, Line 55: static struct timestamp_cache timestamp_cache;
Given that TIMESTAMP_CACHE_IN_BSS is 0 why isn't that as well as this object removed?
Patchset #3 comments. I don't know whether amd/picasso will use .bss or REGION(timestamp) for romstage.
Patch Set #5, Line 168: timestamp_add_table_entry(timestamp_table_get(), id, ts_time);
Below you check the return value of timestamp_table_get() for NULL but you don't here. […]
Done
Patch Set #5, Line 246: static void timestamp_sync_cache_to_cbmem(int is_recovery)
Why did this function move? Can we put it back to its original location for easier reviewing?
Done
To view, visit change 35032. To unsubscribe, or for help writing mail filters, visit settings.