Attention is currently required from: Jason Glenesk, Martin Roth, Marshall Dawson, Karthik Ramasubramanian, Felix Held.

View Change

1 comment:

• File src/mainboard/google/guybrush/variants/baseboard/devicetree.cb:

  • Patch Set #3, Line 55: i2c_pad_ctrl_rx_sel

    Hrmm, it would have been nice to group this with the other i2c config: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/third_party/coreboot/src/soc/amd/cezanne/chip.h;l=16

    How would we feel about adding a voltage into struct dw_i2c_bus_config?

    The other option is we create an AMD specific i2c_bus_config that also contains i2c_scl_reset above. We would need to translate this into a dw_i2c_bus_config in soc_get_i2c_bus_config.

    I kind of like this approach because then we can keep all the configuration grouped.

To view, visit change 55149. To unsubscribe, or for help writing mail filters, visit settings.